feat: add checkbox #975
Merged
feat: add checkbox #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucamejo
pushed a commit
that referenced
this pull request
Nov 4, 2024
* Apply skill effects to target entities when applying damage to them * Add shinko to the characters list * Add shinko skills and params in seeds * Add underscore to discard unused variable in seeds * Fix Shinko ulti params and make his pool effects affect enemies even when they escape it * Make projectiles able to apply an effect on enemies and fix a function taking wrong variable (old effect) * Fix Shinko basic attack params in seeds * Add new boolean to effects to differentiate effects inside pool only vs effects still valid outside them * Fix credo * Fix credo moving code to new function * feat: add checkbox (#975) --------- Co-authored-by: Tomás Villegas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Explain why not how.
Closes #issue_number
Summary of changes
List your changes here.
How to test it?
You can explain how you tested it or suggest a way to do so.
Checklist